Review Request 111291: New Windows solid backend

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111291/#review35251
-----------------------------------------------------------


I am not competent to judge the code, but krita users are ecstatic about the improvements (I've been building installers with this backend for some time now).

- Boudewijn Rempt


On June 28, 2013, 6:05 p.m., Patrick von Reth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111291/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 6:05 p.m.)
> 
> 
> Review request for kdelibs, kdewin and Solid.
> 
> 
> Description
> -------
> 
> 1) Fixes ui blocking
> 2) Fixes problems where some drives could result in a unusable KDE system.
> 3) The wmi backend was "broken" from the beginning because the all wmi calls depend on the wmi host which can be just to slow for intense usage.
> 
> 
> This addresses bugs 178455, 306994 and 314317.
>     http://bugs.kde.org/show_bug.cgi?id=178455
>     http://bugs.kde.org/show_bug.cgi?id=306994
>     http://bugs.kde.org/show_bug.cgi?id=314317
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/win/winstorageaccess.cpp PRE-CREATION 
>   solid/solid/backends/win/winstorageaccess.h PRE-CREATION 
>   solid/solid/backends/win/winprocessor.cpp PRE-CREATION 
>   solid/solid/backends/win/winprocessor.h PRE-CREATION 
>   solid/solid/backends/win/winopticaldrive.cpp PRE-CREATION 
>   solid/solid/backends/win/winopticaldrive.h PRE-CREATION 
>   solid/solid/backends/win/winopticaldisc.cpp PRE-CREATION 
>   solid/solid/backends/win/winopticaldisc.h PRE-CREATION 
>   solid/solid/backends/win/wininterface.cpp PRE-CREATION 
>   solid/solid/backends/win/wininterface.h PRE-CREATION 
>   solid/solid/backends/win/wingenericinterface.cpp PRE-CREATION 
>   solid/solid/backends/win/wingenericinterface.h PRE-CREATION 
>   solid/solid/backends/win/windevicemanager.cpp PRE-CREATION 
>   solid/solid/backends/win/windevicemanager.h PRE-CREATION 
>   solid/solid/backends/win/windevice.cpp PRE-CREATION 
>   solid/solid/backends/win/windevice.h PRE-CREATION 
>   solid/solid/backends/win/winblock.cpp PRE-CREATION 
>   solid/solid/backends/win/winblock.h PRE-CREATION 
>   solid/solid/backends/win/winbattery.cpp PRE-CREATION 
>   solid/solid/backends/win/winbattery.h PRE-CREATION 
>   solid/solid/backends/win/winacadapter.cpp PRE-CREATION 
>   solid/solid/backends/win/winacadapter.h PRE-CREATION 
>   solid/solid/CMakeLists.txt a5aba96b1c8b3f3147e9653ff5f244ea03cf2211 
>   CMakeLists.txt 3d6c6beb8826ed98380d7ba9fa68efe2fde2fcb1 
>   solid/solid/backends/win/winstoragedrive.h PRE-CREATION 
>   solid/solid/backends/win/winstoragedrive.cpp PRE-CREATION 
>   solid/solid/backends/win/winstoragevolume.h PRE-CREATION 
>   solid/solid/backends/win/winstoragevolume.cpp PRE-CREATION 
>   solid/solid/managerbase.cpp beaeac5d39198ce5aa53bea23a032621fa934088 
> 
> Diff: http://git.reviewboard.kde.org/r/111291/diff/
> 
> 
> Testing
> -------
> 
> Testing has been don on windows.
> 
> 
> Thanks,
> 
> Patrick von Reth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20130628/16d8e7c8/attachment.html>