[kde-windows] [Bug 308763] kdepimlibs compilation fails

[Nico Kruber]

https://bugs.kde.org/show_bug.cgi?id=308763

--- Comment #22 from Nico Kruber <nico.kruber at gmail.com> ---
Created attachment 79049
  --> https://bugs.kde.org/attachment.cgi?id=79049&action=edit
fix kdepimlibs compilation on Windows (KDE 4.10.2)

unfortunately, this patch does not seem to have made it into KDE yet and it is
a bit outdated by now

I recently stumbled upon the same compilation issues on Windows with MSVC 2010
and the root cause is not MSVC itself, but QT_NO_CAST_FROM_ASCII being set
(plus one missing include) - the rest may have been fixed in the meanwhile.

Anyway, I propose a new patch for this (I tested windows compilation).
Compared to the previous one, there is a slight difference for strings like
"a.url().toString().toLatin1()" - I assume that this was done on purpose
("a.url().toString()" would otherwise have been valid, too) in order to remove
non-Latin1 characters. So I kept this behaviour - in this particular case, it
translates into:

const QByteArray& lat1Url = a.url().toString().toLatin1();
QString::fromLatin1(lat1Url.constData(), lat1Url.size())

-- 
You are receiving this mail because:
You are the assignee for the bug.