Review Request: Make the kdewin-installer compile on linux

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106534/#review19341
-----------------------------------------------------------

Ship it!


Please remove the unneeded message output and commit it.


CMakeLists.txt
<http://git.reviewboard.kde.org/r/106534/#comment15293>

    Hm, this looks suspicious that you don't have QT_CONFIG shared; no idea how portable our tests are at that point though. (maybe make a comment here if you can find out why it is like that.)



CMakeLists.txt
<http://git.reviewboard.kde.org/r/106534/#comment15294>

    no message lalalala in our code please XDXDXD


- Patrick Spendrin


On Sept. 22, 2012, 8:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106534/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2012, 8:29 p.m.)
> 
> 
> Review request for kdewin, Patrick Spendrin and Patrick von Reth.
> 
> 
> Description
> -------
> 
> Hi, since I wanted to see what is possible and what not with the kdewin installer I decided to take a look into the code and compile it and all.
> 
> Here I'm sending the changes I had to make so that it worked properly.
> 
> I understand you might want some of the changes and some not, but I think there are some good changes like proper casing in includes or fixing the non-static compilation that can be useful.
> 
> Feel free to reject it anyway :P.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 65cf501 
>   CMakeLists.txt f62fea8 
>   shared/CMakeLists.txt 3257b62 
>   shared/externalinstallercontrol.cpp 018ff96 
>   shared/installercallconfig.cpp b290298 
>   shared/installerengine.cpp 181a504 
>   shared/settings.cpp 419349c 
>   single-package-installer/CMakeLists.txt 0b0de3d 
>   single-package-installer/installerdialog.h 1619025 
>   single-package-installer/installerenginesinglepackage.cpp fc43a26 
> 
> Diff: http://git.reviewboard.kde.org/r/106534/diff/
> 
> 
> Testing
> -------
> 
> Compiled it on Archlinux, made it run for a bit xD.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20120922/e431a6c8/attachment.html>