Review Request: Rekonq - Fix Windows build and MSVC warnings.

Andrea Diamantini adjam7 at gmail.com
Fri May 25 16:29:08 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105022/#review14163
-----------------------------------------------------------

Ship it!


Every change here seems safe. Feel free to commit (rebasing before) when you like (hopefully in 2/3 days). If you can't/want commit it yourself, just say it here and I'll take care of.

Many thanks for this.

- Andrea Diamantini


On May 24, 2012, 2:03 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105022/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 2:03 a.m.)
> 
> 
> Review request for kdewin, rekonq and Andrea Diamantini.
> 
> 
> Description
> -------
> 
> Some small fixes for MSVC build (detailed comments in the review request diff view).
> 
> 
> Diffs
> -----
> 
>   src/application.cpp ef6c208 
>   src/bookmarks/bookmarkowner.cpp be28448 
>   src/mainview.h a80ba52 
>   src/opensearch/suggestionparser.h c8a61b9 
>   src/webpage.cpp ce1151d 
> 
> Diff: http://git.reviewboard.kde.org/r/105022/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20120525/7ad2948e/attachment.html>


More information about the Kde-windows mailing list