Review Request: KWebKitPart - Fix Windows build

[Dawit Alemayehu]

> On May 21, 2012, 6:21 a.m., Dawit Alemayehu wrote:
> > src/sslinfodialog_p.h, line 45
> > <http://git.reviewboard.kde.org/r/105002/diff/1/?file=65048#file65048line45>
> >
> >     You can simply remove the KDE_EXPORT. I should have really removed that before adding that header file. It is a private header file after all and is only there to make it possible to compile the code.
> 
> Andrius da Costa Ribas wrote:
>     This is wrong in KIO. If it's a private header, it should not export that class, however this means we would not be able to use it. On MSVC it works without the macro, but using it is more compiler-optimized.

It is exported in KIO for internal reasons and as such the header file is not installed. So long as it compiles then that is fine. Soon enough kwebkitpart will get its own SSL display dialog and this issue will become a moot point then.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105002/#review14008
-----------------------------------------------------------


On May 20, 2012, 10:07 p.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105002/
> -----------------------------------------------------------
> 
> (Updated May 20, 2012, 10:07 p.m.)
> 
> 
> Review request for kdewin, kwebkitpart and Maks Orlovich.
> 
> 
> Description
> -------
> 
> 2 small points to fix Windows build of KWebKitPart.
> 
> 1- We're always KDE_IMPORTing the KSslInfoDialog - symbol export/importing problems are often not detected on linux.
> 2- ifdef'd a X11 header (but probably it isn't needed at all).
> 
> 
> Diffs
> -----
> 
>   src/settings/webkit_filter.cpp 2fc48da 
>   src/sslinfodialog_p.h de061e5 
> 
> Diff: http://git.reviewboard.kde.org/r/105002/diff/
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010 on a Win7 64bit machine. Works pretty fine on Konqueror :)
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20120523/81f6b579/attachment.html>