Review Request: systemsettings/fonts: DPI setting is X11-only

Christoph Feck christoph at maxiom.de
Wed Sep 21 12:42:53 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102527/#review6696
-----------------------------------------------------------

Ship it!


- Christoph


On Sept. 4, 2011, 9:37 a.m., Lukas Sommer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102527/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 9:37 a.m.)
> 
> 
> Review request for KDE Base Apps, KDE Runtime and kdewin.
> 
> 
> Summary
> -------
> 
> In systemsettings/fonts, the DPI setting affects only X11. Therefor, this setting should only be enabled when compiling on X11 (and not for compiling on MS Windows or other non-X11 window systems).
> 
> 
> Diffs
> -----
> 
>   kcontrol/fonts/fonts.h 7f1c2d0 
>   kcontrol/fonts/fonts.cpp 5a1728d 
> 
> Diff: http://git.reviewboard.kde.org/r/102527/diff
> 
> 
> Testing
> -------
> 
> Tested on X11, adding an "#undef Q_WS_X11" for testing purpose.
> 
> 
> Thanks,
> 
> Lukas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20110921/42359a00/attachment.html>


More information about the Kde-windows mailing list