Review Request: W7 Tab thumbnails in dolphin.

Wed Oct 5 00:52:44 UTC 2011

> On Oct. 3, 2011, 1:15 p.m., David Faure wrote:
> > Couldn't this be done higher in the stack, e.g. in KTabWidget or in Qt?
> 
> Kevin Kofler wrote:
>     Indeed, I think there should be some interface for this stuff in kdelibs, so that 1. applications don't have to add such platform-specific code and 2. the feature can also be implemented for our own Plasma Desktop workspace, and applications will automatically benefit (whereas with the current solution, they'd need more platform-specific code doing the same thing). Seeing KDE applications doing more things in a foreign desktop workspace than in our own doesn't look right to me. :-(
>     
>     (Yet another kdelibs feature that would justify doing a 4.8 release…)
> 
> Martin Gräßlin wrote:
>     if anyone wants to do the bits for Plasma, please see http://community.kde.org/KWin/Browser_Integration
>     
>     It just needs someone to implement and at least Mozilla already showed interest in adding support if we add that.
> 
> Andrius da Costa Ribas wrote:
>     My thoughts:
>     - I did an first experiment with dolphin only, but yes, we all agree this might be inside some sort of library.
>     - I don't think KTabWidget is an appropriate place to place this either, since we may want to generate previews of non tabbed interfaces (Konversation and Kate don't necessarily use tabs). It would be better to bind such interface into a KApplication (but not necessarily making it inside KApplication)
>     - (this one more kind of brainstorming) Reading Martin and Kevin's comments, I think it would be good to have a single interface to window managers, in the same way phonon address multimedia stuff so the app should not care about whether VLC, Xine or DirectSound is being used, in the same way solid address hardware stuff so the app should not care about whether WMI or HAL is being used, this interface should work in a way the app should not care whether KWin, Mutter or dwm.exe is being used.
>     - "Seeing KDE applications doing more things in a foreign desktop workspace than in our own doesn't look right to me." - To me this would not look right if we were talking about GnomeShell or other X11 desktop... in this case I see this more like an OS thing (given that explorer can be replaced, but dwm can't). Also, I think implementing something ready for a foreign desktop encourages making the "native" desktop ready for it too ;).
>     
>     @Martin: I know almost nothing about x11-specific stuff to help out with plasma/kwin, but according to that link, the required elements are almost the same ( icon + title + thumbnail ), so I think it may be not hard to have a common interface, not just for this feature but for other wm features too ( I'm thinking about thumbnail toolbars on amarok and kopete, just like the ones in wmp, wlm and skype ;] )
>

I'm closing this request as "discarded". By now I think the patch can be used in emerge scripts to help out tracking issues with this on different compilers and different windows boxes. I would like to know from plasma/kwin people their thoughts about a common interface as mentioned in my previous comment.

- Andrius da Costa

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102758/#review7032
-----------------------------------------------------------

On Oct. 5, 2011, 12:52 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102758/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2011, 12:52 a.m.)
> 
> 
> Review request for KDE Base Apps, KDE Accessibility, kdewin, Plasma, Patrick Spendrin, and Peter Penz.
> 
> 
> Description
> -------
> 
> Add Windows 7 tab thumbnails feature to dolphin.
> Mostly based on the example from <http://nicug.blogspot.com/2011/03/windows-7-taskbar-extensions-in-qt-tab.html>.
> 
> An icon representation is used instead of actual thumbnails ( please agree that those microscopic previews are not useful at all ;] ). Changing an icon when url changes is also easier than checking all the time whether something inside the window has been changed. Using icons is a lot more KDE-ish and therefore more beautiful and user-friendly than the default Windows behavior ;).
> 
> "win7utils.h" and "win7utils.cpp" are from <https://github.com/xfreebird/blogstuff/tree/master/qt/thumbnailtabs_example1> with few adaptations.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 93225c5 
>   dolphin/src/dolphinapplication.h 69d07c3 
>   dolphin/src/dolphinapplication.cpp 0dc9c96 
>   dolphin/src/dolphinmainwindow.h 9fb83bf 
>   dolphin/src/dolphinmainwindow.cpp 6ca6e59 
>   dolphin/src/platform/win7utils.h PRE-CREATION 
>   dolphin/src/platform/win7utils.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102758/diff/diff
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010 32 bit, in a Windows 7 64 bit machine.
> 
> May need testing:
> - Compiling under mingw-w32 and mingw-w64
> - Using Windows Vista or below to ensure there are no side-efects on a box without this feature.
> - Using Windows 8 (I don't know much about its bugs^H^H^H^Hfeatures ;] )
> 
> Known problems:
> - There is no way to know if KTabBar got a tab reordered, so the "thumbnails" won't be reordered, but their reference is still correct
> - Undefined behavior when dolphin gets unresponsive [e.g.: because of a defective kioslave], most of the code assume dolphin is okay [e.g.: QPixmap::grabWidget won't work in a frozen window]. 
> 
> 
> Screenshots
> -----------
> 
> Tabs!
>   http://git.reviewboard.kde.org/r/102758/s/281/
> More Tabs!
>   http://git.reviewboard.kde.org/r/102758/s/282/
> Too many tabs!
>   http://git.reviewboard.kde.org/r/102758/s/283/
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20111005/e7dbbed7/attachment-0001.html>