Review Request: KWorkspace: Fix linking issues under windows and link it consistently, independently of the OS.

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103061/#review8007
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Nov. 7, 2011, 12:04 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103061/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2011, 12:04 a.m.)
> 
> 
> Review request for kdewin and Plasma.
> 
> 
> Description
> -------
> 
> KWorkspace is currently built statically under windows, but there are several places it is not linked. There is no apparent reason for that. Also, dll linkage (import/exoirt) was not correct for building it as a dynamic lib. "kworkspace_export.h" and related changes are based on the code under libs/oxygen.
> 
> 
> Diffs
> -----
> 
>   libs/kworkspace/CMakeLists.txt 32cd11d 
>   libs/kworkspace/kactivityconsumer.h 901aac1 
>   libs/kworkspace/kactivitycontroller.h 3a02825 
>   libs/kworkspace/kactivityinfo.h 3e271de 
>   libs/kworkspace/kdisplaymanager.h c215137 
>   libs/kworkspace/kwindowlistmenu.h 2fe601b 
>   libs/kworkspace/kworkspace.h 8868bf6 
>   libs/kworkspace/kworkspace_export.h PRE-CREATION 
>   libs/kworkspace/screenpreviewwidget.h 3ebb047 
>   plasma/desktop/applets/kickoff/CMakeLists.txt bc5fa2e 
>   plasma/generic/applets/lock_logout/CMakeLists.txt 8381d46 
>   plasma/generic/containmentactions/contextmenu/CMakeLists.txt a1fc205 
> 
> Diff: http://git.reviewboard.kde.org/r/103061/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled under MSVC 2010. I'm looking other non-related issues that prevents other parts of kde-workspace being built completely.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-windows/attachments/20111107/bddf6185/attachment.html>