Review Request: GitSource: define a helper for calling git, suppress progress info for logfile

[Wolfgang Rohdewald]

> On March 26, 2011, 6:03 p.m., Ralf Habacker wrote:
> > in Line 209 there is a difference 
> > - '-p %d' 
> > +  '-p%d'
> > 
> > otherwise looks good. 
> >

actually it was -p %s before where %s is a digit. If you look at "man patch" you will see that they always write -pnum without a space, so I would say '-p%d' is more correct than '-p %d'


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6613/#review10029
-----------------------------------------------------------


On March 15, 2011, 12:07 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6613/
> -----------------------------------------------------------
> 
> (Updated March 15, 2011, 12:07 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> - no hanging git when cloning qt
> - calling git directly (no MSysShell needed anymore with current git)
> - much less clutter in the logfile without MSysShell
> 
> however this does more calls to checkoutDir(). I have one more patch which
> caches this within GitSource but it depends on this patch
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/Source/GitSource.py 1224972 
> 
> Diff: http://svn.reviewboard.kde.org/r/6613/diff
> 
> 
> Testing
> -------
> 
> building qt and kdelibs
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110327/90ff9267/attachment.htm