Review Request: Windows standard make command

[Andreas Pakulat]

> On March 5, 2011, 5:50 p.m., Milian Wolff wrote:
> > projectbuilders/makebuilder/CMakeLists.txt, line 39
> > <http://git.reviewboard.kde.org/r/100803/diff/1/?file=10590#file10590line39>
> >
> >     is the new file just there for the default value? I don't like that, rather I'd set the different default in the settings code (where the ui is displayed)
> 
> Andreas Holzammer wrote:
>     i dont like the extra files too, but i dont know another solution for changing the standard value in the kcfg for a specific platform. i will try to find a better solution, but i guess there is not really one, because we did simular things before in the komo project.

IIRC kcfg supports providing actual C++ code for calculating the default value, that way you can support both platforms with 1 kcfg file. It should be as simple as having a default-element with code="true" attribute and C++ code as content.


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100803/#review1781
-----------------------------------------------------------


On March 5, 2011, 4:32 p.m., Andreas Holzammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100803/
> -----------------------------------------------------------
> 
> (Updated March 5, 2011, 4:32 p.m.)
> 
> 
> Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> The standard make command is nmake under windows. This patch changes the standard make command under Windows.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/CMakeLists.txt e2c599089978dc8e3c4879ca02a92bd725fb9f2f 
>   projectbuilders/makebuilder/makebuilderconfig_msvc.kcfg PRE-CREATION 
>   projectbuilders/makebuilder/makebuilderconfig_msvc.kcfgc PRE-CREATION 
>   projectbuilders/makebuilder/makejob.cpp fd314516da56a28955793f343ac403e8ef483d4d 
> 
> Diff: http://git.reviewboard.kde.org/r/100803/diff
> 
> 
> Testing
> -------
> 
> compiled a test project and it worked.
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110306/98027805/attachment.htm