Review Request: Standard cmake generator under Windows

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100802/#review1793
-----------------------------------------------------------

Ship it!


Yeah, the hunk about the kcfg-file seems wrong/unrelated so remove that. Otherwise the patch is ok, though it might be even nicer if the user could choose the generator on the cmake-builddir-config page so that people using jom can use the specific jom-generator. Oh and of course it should also be possible to generate a VS solution and run that via MS devenv (or whatever the cli-tool for building that was called).

- Andreas


On March 5, 2011, 4:29 p.m., Andreas Holzammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100802/
> -----------------------------------------------------------
> 
> (Updated March 5, 2011, 4:29 p.m.)
> 
> 
> Review request for KDevelop, kdewin, Milian Wolff, and Patrick Spendrin.
> 
> 
> Summary
> -------
> 
> Under Windows the standard cmake generator is a Visual Studio Solution. We cannot compile such a solution, so we need to generate a nmake Makefile by standard. This patch adds the generator to the cmake commandline
> 
> 
> Diffs
> -----
> 
>   projectbuilders/cmakebuilder/cmakejob.cpp bd8a76a9835239234e715c212ff8587d0346d7ce 
>   projectmanagers/cmake/CMakeLists.txt 6f8bf025b40acee28f8c54e4d03f09a407e73ed2 
> 
> Diff: http://git.reviewboard.kde.org/r/100802/diff
> 
> 
> Testing
> -------
> 
> I tried to open a cmake project and let him generate a project. worked.
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110305/c5bb00dc/attachment.htm