Review Request: Simplify SourceBase.applyPatches

[Wolfgang Rohdewald]

> On March 2, 2011, 3:05 p.m., Ralf Habacker wrote:
> > moving applyPatches looks as a good idea to me. I suggest to add these method to the api screenshots in emerge/doc/refactoring-2009
> >

I am not sure I understand you here - I did not want to change the API of any classes, only
eliminate utils.applyPatch() - but that too has to wait until base.py does not need it any more


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6527/#review9934
-----------------------------------------------------------


On Feb. 27, 2011, 10:49 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6527/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2011, 10:49 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> simplifies the source code. Make no exception for being called with only one patch.
> Remove warning for failed patch from applyPatches, applyPatch warns.
> log a warning if applyPatch is called without a patch file name
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/Source/SourceBase.py 1222425 
>   /trunk/kdesupport/emerge/bin/utils.py 1222512 
> 
> Diff: http://svn.reviewboard.kde.org/r/6527/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110302/b043131c/attachment.htm