Review Request: utils / manifests: Cleanup, fixes

[Wolfgang Rohdewald]

> On March 2, 2011, 12:22 p.m., Ralf Habacker wrote:
> > looks good 
> > 
> > 
> >

just a side note about the wrong hash for uactools-20101219-bin.mft: This only uncovers another problem:
this hash should not exist in the manifest file at all - if file X contains its own hash, it is always wrong
(well, in practice at least)


- Wolfgang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6524/#review9929
-----------------------------------------------------------


On Feb. 19, 2011, 2:58 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6524/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2011, 2:58 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> It happened to me that a manifest file did not exist when emerge tried to open it and emerge died, so I looked closer at this code.
> 
> After some refactoring, this is fixed. Also:
> 
> - removing code duplication: less source code
> - more complete docstrings
> - if a manifest file appears twice in *.mft, emerge tried to delete it twice, so it
>   logged a warning about a missing file. Fixed.
> - in the same situation, if one of the entries had a hash and the other not, the hash
>   was not checked before deleting. Now it is.
> 
> those 2 problems happen with dev-util/uactools, unmerging this will now result in a
> warning that uactools-20101219-bin.mft has a wrong hash (which it has).
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/utils.py 1221559 
> 
> Diff: http://svn.reviewboard.kde.org/r/6524/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110302/c4e1f409/attachment-0001.htm