Review Request: portage.py: a few code simplifications

Ralf Habacker ralf at habacker.de
Wed Mar 2 13:04:07 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6515/#review9928
-----------------------------------------------------------

Ship it!


looks good

- Ralf


On Feb. 18, 2011, 11:45 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6515/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2011, 11:45 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> no change in functionality
> 
> including one small fix:
> 
> if len(x) is 1 
> 
> is wrong - depending on python implementation, this might return False instead of True
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/portage.py 1221544 
> 
> Diff: http://svn.reviewboard.kde.org/r/6515/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110302/af3bbe18/attachment.htm 


More information about the Kde-windows mailing list