Review Request: Use QDirIterator in KStandardDirs

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101554/#review3799
-----------------------------------------------------------


my biggest question with this change would be performance. QFileInfo is not fast, and to make matters "worse" this code in KStandardDirs influences start up speed. have you measured the performance after this change relative to before?

with Qt5 this may become a moot issue with the changes coming in the QFile backends ... but i don't think it makes sense to introduce possible performance regressions on code that currently works.

is there a platform for which the current code fails?

- Aaron J.


On June 9, 2011, 7:06 a.m., Bernhard Beschow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101554/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 7:06 a.m.)
> 
> 
> Review request for kdelibs, kdewin and David Faure.
> 
> 
> Summary
> -------
> 
> Increase portability of kdecore a tiny bit by making KStandardDirs use QDirIterator rater than platform-specific code.
> 
> 
> Diffs
> -----
> 
>   kdecore/kernel/kstandarddirs.cpp ba90270 
> 
> Diff: http://git.reviewboard.kde.org/r/101554/diff
> 
> 
> Testing
> -------
> 
> I'm running my platform 4.6 with this patch and haven't noticed any regressions yet.
> 
> 
> Thanks,
> 
> Bernhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110609/5c402a78/attachment.htm