Review Request: remove unneeded attributes from NullsoftInstallerPackage

Ralf Habacker ralf.habacker at freenet.de
Tue Jan 18 21:41:28 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6344/#review9651
-----------------------------------------------------------

Ship it!


looks good to me

- Ralf


On Jan. 16, 2011, 11:23 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6344/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2011, 11:23 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
>     NullsoftInstallerPackager: eliminate attributes whitelists and blacklists
>     they are not used anywhere outside of __init__
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py 1214807 
> 
> Diff: http://svn.reviewboard.kde.org/r/6344/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110118/71924a12/attachment.htm 


More information about the Kde-windows mailing list