dumpDependencies: obsolete code?

[Ralf Habacker]

Am 15.1.2011 18:28, schrieb Wolfgang Rohdewald:
>
> of the BuildSystem classes, only CMakeBuildSystem overrides
>
> the abstract method BuildSystemBase.dumpDependencies. And
>
> the implementation in CMakeBuildSystem is not functional as
>
> it calls the non existant dumpEmergeDependencies.
>
This function has been introduced at 
http://websvn.kde.org/trunk/kdesupport/emerge/bin/Package/PackageBase.py?r1=1177558&r2=1177767 
but has been renamed later by accident.

CMakeBuildSystem provides an extension to the basic dumpDependencies 
(cmake + emerge dependencies), wh
>
> am I right in assuming that all this is nowadays done thru
>
> PackageBase and descendants?
>
no, dumpDependencies is defined in BuildSystemBase.


> DumpDependencies exists in
>
> PackageBase and VirtualPackagebase and is actually used.
>
which is wrong, see above.

In latest svn r1214644 it looks right.


Because cmake dependencies is a feature of CMakeBuildSystem, which is a 
build system I moved the implementation of dumpEmergeDependencies from 
PackageBase into BuildSystemBase class to be in the direct derivation line

Ralf



-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110115/22c930f5/attachment.htm