seems like a bug in NullsoftInstallerPackage

Wolfgang Rohdewald wolfgang at rohdewald.de
Wed Jan 12 22:32:33 CET 2011


On Mittwoch 12 Januar 2011, Ralf Habacker wrote:
> Am 12.01.2011 19:53, schrieb Wolfgang Rohdewald:
> > in createPackage:
> > 
> > copyFiles should probably use imageDir and not
> > self.imageDir()
> 
> no - self.imageDir() is located in EmergeBase - in EmergeBase
> there are methods which are used by all other classes in
> Source, Package, BuildSystem and Packager subdirs.

in that case, the lines below are dead code and should be
removed.

At second glance, they are nonsense anyway: joining a function
with a string. Obviously mergeDir is never True, or this
bug would have been noticed.

imageDir = self.imageDir()
if mergeDir:
    imageDir = os.path.join( self.imageDir, mergeDir )


-- 
Wolfgang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110112/b382bab2/attachment.htm 


More information about the Kde-windows mailing list