bug in EmergeBase.__init__

[Wolfgang Rohdewald]

On Mittwoch 12 Januar 2011, Wolfgang Rohdewald wrote:
> On Mittwoch 12 Januar 2011, Ralf Habacker wrote:
> > this is not true  - in files below the portage subdir there
> > are class  instantiation like shown below:
> > 
> > class Package(CMakePackageBase):
> >      def __init__( self ):
> >          self.subinfo = subinfo()
> >          CMakePackageBase.__init__( self )
> > 
> > self.subinfo is present before EmergeBase has been
> > instantiated.
> > 
> > Ralf
> 
> you are right - I just got this suspicion and was going
> to check but you were faster. Sorry for the noise.
> 
> I cannot say I really like this - better IMHO would be
> for EmergeBase:
> 
> def __init__(self, subinfo=None)
>    self.subinfo = subinfo

that would also need this patch - the only one I found yet:
--- a/bin/EmergeBase.py
+++ b/bin/EmergeBase.py
@@ -120,7 +120,7 @@ class EmergeBase(object):
             print >> sys.stderr, "emerge error: KDECOMPILER: 
'%s' not understood" % COMPILER
             exit( 1 )
         self.rootdir = ROOTDIR
-        if hasattr(self, "subinfo"):
+        if self.subinfo:
             self.setup()



-- 
Wolfgang
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110112/b5b9fe9f/attachment.htm