Review Request: Packagers: remove duplicate code, consistent naming, simplify some code

[Wolfgang Rohdewald]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6486/
-----------------------------------------------------------

(Updated Feb. 18, 2011, 8:36 a.m.)


Review request for kde-windows.


Changes
-------

fixed a stupid typo in my last change, sorry for the noise


Summary
-------

__installedDBPrefix existed identically in PackageBase and InternalPackageBase. Remove it from InternalPackageBase and rename to _installedDBPrefix

rename self.packager to self.packagerExe for consistency

simplify code in PackagerFactory (this code is actually unused but it looks like a plan for the future)

a few other small simplifications around packager code


Diffs (updated)
-----

  /trunk/kdesupport/emerge/bin/Package/InternalPackageBase.py 1221360 
  /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1221360 
  /trunk/kdesupport/emerge/bin/Packager/InnoSetupPackager.py 1221360 
  /trunk/kdesupport/emerge/bin/Packager/KDEWinPackager.py 1221360 
  /trunk/kdesupport/emerge/bin/Packager/PackagerFactory.py 1221360 
  /trunk/kdesupport/emerge/bin/Packager/SevenZipPackager.py 1221360 

Diff: http://svn.reviewboard.kde.org/r/6486/diff


Testing
-------


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110218/3f740b0d/attachment.htm