Review Request: fix --cleanallbuilds
Ralf Habacker
ralf at habacker.de
Fri Feb 18 08:09:16 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6502/#review9877
-----------------------------------------------------------
Ship it!
> I hope this is what --cleanallbuilds is supposed to to.
yes, patch looks good - many thans for your contribution
- Ralf
On Feb. 16, 2011, 11:43 p.m., Wolfgang Rohdewald wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6502/
> -----------------------------------------------------------
>
> (Updated Feb. 16, 2011, 11:43 p.m.)
>
>
> Review request for kde-windows.
>
>
> Summary
> -------
>
> emerge --cleanallbuilds resulted in an error message. There is EmergeBase.cleanAllBuilds() but this will never be called, so remove it.
>
> implement --cleanallbuilds in emerge.py, removing everything in %KDEROOT%\build
>
> I hope this is what --cleanallbuilds is supposed to to.
>
>
> Diffs
> -----
>
> /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1221105
> /trunk/kdesupport/emerge/bin/emerge.py 1221119
>
> Diff: http://svn.reviewboard.kde.org/r/6502/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wolfgang
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110218/0e32b376/attachment.htm
More information about the Kde-windows
mailing list