Review Request: use utils.envAsBool() for all boolean environment variables

Fri Feb 18 08:07:11 CET 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6501/#review9876
-----------------------------------------------------------

Ship it!

looks good

- Ralf

On Feb. 16, 2011, 11:05 p.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6501/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 11:05 p.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> This fixes several problems:
> 
> - sometimes emerge checks for True, sometimes for 1, sometimes for both
> 
> - emerge sometimes interprets every value as True, even False - like
>   EMERGE_NO_PASSIVE_FTP or EMERGE_ENABLE_IMPLICID_BUILDTIME_DEPENDENCIES.
>   emerge only checks if those variables are set, ignoring their value.
> 
> - EmergeBase.py interprets EMERGE_NOFAST the wrong way round.
>   This patch makes EmergeBase behave like base.py
> 
> - remove dead code in emerge.py
> 
> envAsBool accepts 'True' (ignoring case) and '1' for True, everything else is False.
> The default for a non-existing environment variable can be passed.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/EmergeBase.py 1221105 
>   /trunk/kdesupport/emerge/bin/InstallDB.py 1221105 
>   /trunk/kdesupport/emerge/bin/Package/PackageBase.py 1221105 
>   /trunk/kdesupport/emerge/bin/Packager/NullsoftInstallerPackager.py 1221105 
>   /trunk/kdesupport/emerge/bin/Source/ArchiveSource.py 1221105 
>   /trunk/kdesupport/emerge/bin/Source/GitSource.py 1221105 
>   /trunk/kdesupport/emerge/bin/Source/SvnSource.py 1221105 
>   /trunk/kdesupport/emerge/bin/Source/VersionSystemSourceBase.py 1221105 
>   /trunk/kdesupport/emerge/bin/base.py 1221107 
>   /trunk/kdesupport/emerge/bin/emerge.py 1221119 
>   /trunk/kdesupport/emerge/bin/kde_build.py 1221105 
>   /trunk/kdesupport/emerge/bin/options.py 1221105 
>   /trunk/kdesupport/emerge/bin/portage.py 1221105 
>   /trunk/kdesupport/emerge/bin/tools.py 1221105 
>   /trunk/kdesupport/emerge/bin/utils.py 1221105 
>   /trunk/kdesupport/emerge/bin/win32libsupdater.py 1221105 
>   /trunk/kdesupport/emerge/portage/virtual/base/base-0.2.py 1221099 
>   /trunk/kdesupport/emerge/portage/virtual/bin-base/bin-base-0.2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/assuan2/assuan2-400.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/boost/boost-1.44.0-1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/chm/chm-0.40.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/clucene-core/clucene-core-0.9.21b.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/cyrus-sasl/cyrus-sasl-2.1.22.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/djvu/djvu-3.5.23.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/ebook-tools/ebook-tools-0.2.1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/exiv2/exiv2-0.21-2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/expat/expat-2.0.1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/freetype/freetype-2.3.12-2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/gettext/gettext-0.18.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/giflib/giflib-4.1.6.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/gpg-error/gpg-error-267.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/gpgme/gpgme-1510.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/jasper/jasper-1.900.1-2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/jpeg/jpeg-8.0.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/lcms/lcms-1.19-2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libarchive/libarchive-2.8.4.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libbfd/libbfd-2.20.1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libbzip2/libbzip2-1.0.6-1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libcurl/libcurl-7.20.0.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libfftw/libfftw-3.2.2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libical/libical-0.44.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libidn/libidn-1.19-5.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/liblzma/liblzma-5.0.0.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libmsn/libmsn-4.1-2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libnova/libnova-0.13.0+svn270.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libogg/libogg-1.2.0.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libpng/libpng-1.4.4.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libsamplerate/libsamplerate-0.1.7.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libsndfile/libsndfile-1.0.21.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libspectre/libspectre-0.2.6.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libvorbis/libvorbis-1.3.1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libxml2/libxml2-2.7.7.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libxslt/libxslt-1.1.26.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/libzip/libzip-0.9.3.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/openbabel/openbabel-2.2.3.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/openjpeg/openjpeg-1.3-2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/openslp/openslp-1.2.1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/openssl/openssl-1.0.0b.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/pcre/pcre-8.10.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/redland/redland-1.0.8.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/shared-mime-info/shared-mime-info-0.71-1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/sqlite/sqlite-3.7.2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/taglib-extras/taglib-extras-1.0.1.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/taglib/taglib-1.6.3.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/tiff/tiff-3.9.2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/win_iconv/win_iconv-0.0.2.py 1221099 
>   /trunk/kdesupport/emerge/portage/win32libs-bin/zlib/zlib-1.2.5.py 1221099 
> 
> Diff: http://svn.reviewboard.kde.org/r/6501/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110218/b409533f/attachment-0001.htm 