Review Request: define and use a wrapper for getting EMERGE_PKGDSTDIR

Wolfgang Rohdewald wolfgang at rohdewald.de
Wed Feb 16 20:54:34 CET 2011


On Mittwoch 16 Februar 2011, Ralf Habacker wrote:
> > On Feb. 16, 2011, 9:48 a.m., Ralf Habacker wrote:
> > > looks good
> > 
> > You added build type support 
> 
> explanation: I use one root for different build types enabled
> with EMERGE_MERGE_ROOT_WITH_BUILD_TYPE. The merge destination
> roots are below root dir as shown here:

but why do the baseclass - based packages not support this?

bin/base.py:        dstpath = self.packageDestinationDir(withBuildType=False)
bin/Packager/InnoSetupPackager.py:        dstpath = self.packageDestinationDir(withBuildType=False)
portage/enterprise5/l10n-kde4-e5/l10n-kde4-e5-20110117.py:        dstpath = self.packageDestinationDir(withBuildType=False)
portage/kde-4.1/l10n-kde4/l10n-kde4-20080320.py:        dstpath = self.packageDestinationDir(withBuildType=False)
portage/kde-4.2/l10n-kde4/l10n-kde4-20080320.py:        dstpath = self.packageDestinationDir(withBuildType=False)
portage/contributed/l10n-kde4-branch/l10n-kde4-branch-20080626.py:        dstpath = self.packageDestinationDir(withBuildType=False)

-- 
Wolfgang


More information about the Kde-windows mailing list