Review Request: use BuildSystemBase.makeOptions() instead of duplicating its code

[Ralf Habacker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6492/#review9863
-----------------------------------------------------------

Ship it!


looks good

- Ralf


On Feb. 16, 2011, 9:25 a.m., Wolfgang Rohdewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6492/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2011, 9:25 a.m.)
> 
> 
> Review request for kde-windows.
> 
> 
> Summary
> -------
> 
> this changes behaviour in that there are more places now where VERBOSE=1 might be appended
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/emerge/bin/BuildSystem/AutoToolsBuildSystem.py 1221077 
>   /trunk/kdesupport/emerge/bin/BuildSystem/BuildSystemBase.py 1221077 
>   /trunk/kdesupport/emerge/bin/BuildSystem/CMakeBuildSystem.py 1221079 
>   /trunk/kdesupport/emerge/bin/BuildSystem/MakeFileBuildSystem.py 1221079 
>   /trunk/kdesupport/emerge/bin/BuildSystem/QMakeBuildSystem.py 1221077 
> 
> Diff: http://svn.reviewboard.kde.org/r/6492/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wolfgang
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110216/a71774b5/attachment.htm