Review Request: define and use a wrapper for getting EMERGE_PKGDSTDIR

Wolfgang Rohdewald wolfgang at rohdewald.de
Wed Feb 16 09:49:34 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6490/
-----------------------------------------------------------

(Updated Feb. 16, 2011, 8:49 a.m.)


Review request for kde-windows.


Changes
-------

I should sync more frequently...

now I added parameter withBuildType=True, so it can also be used for InnoSetup

and I put the same into deprecated base so that all packages can make use of this

You added build type support in some places but I don't know where this is wanted and where not so I did not change behaviour


Summary
-------

define pkgDstDir() in EmergeBase and base: gets EMERGE_PKGDSTDIR with default %KDEROOT%/tmp


Diffs (updated)
-----

  /trunk/kdesupport/emerge/bin/EmergeBase.py 1221078 
  /trunk/kdesupport/emerge/bin/Packager/InnoSetupPackager.py 1221077 
  /trunk/kdesupport/emerge/bin/base.py 1221077 
  /trunk/kdesupport/emerge/portage/contributed/l10n-kde4-branch/l10n-kde4-branch-20080626.py 1221077 
  /trunk/kdesupport/emerge/portage/enterprise5/l10n-kde4-e5/l10n-kde4-e5-20110117.py 1221077 
  /trunk/kdesupport/emerge/portage/kde-4.1/l10n-kde4/l10n-kde4-20080320.py 1221077 
  /trunk/kdesupport/emerge/portage/kde-4.2/l10n-kde4/l10n-kde4-20080320.py 1221077 

Diff: http://svn.reviewboard.kde.org/r/6490/diff


Testing
-------


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110216/4079078c/attachment.htm 


More information about the Kde-windows mailing list