Review Request: remove unused code
Ralf Habacker
ralf at habacker.de
Wed Feb 16 08:37:36 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6485/#review9858
-----------------------------------------------------------
Ship it!
looks good
- Ralf
On Feb. 15, 2011, 5:15 p.m., Wolfgang Rohdewald wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6485/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2011, 5:15 p.m.)
>
>
> Review request for kde-windows.
>
>
> Summary
> -------
>
> EmergeBase: devUtilsRoot, filesDir and enterImageDir are never used, remove them
>
> this patch also contains a few fixes for whitespace which crept back in. If your editors can be adjusted to strip trailing spaces and to never save tabs for python files, please do! (eric does both)
>
>
> Diffs
> -----
>
> /trunk/kdesupport/emerge/bin/EmergeBase.py 1220833
> /trunk/kdesupport/emerge/portage/templates/binaryPackage/binaryPackage-0.0.0.py 1220833
> /trunk/kdesupport/emerge/portage/templates/cmakePackage/cmakePackage-0.0.0.py 1220833
>
> Diff: http://svn.reviewboard.kde.org/r/6485/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Wolfgang
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-windows/attachments/20110216/ce7cbdb7/attachment.htm
More information about the Kde-windows
mailing list