Review Request: Fixes for KUrlNavigator on windows

Patrick Spendrin ps_ml at gmx.de
Mon Dec 27 22:47:29 CET 2010


Am 27.12.2010 21:47, schrieb Romain Pokrzywka:
> I'm not on reviewboard so I can't act on that request, but it looks good to me (fwiw)
> 
> Thanks for the patch !
> Cheers
> 
> Romain

Then I'd say just go ahead and commit to trunk at least. I am not sure
if we are allowed to commit a new feature also to 4.6 branch?

regards,
Patrick

> 
> On Saturday 25 December 2010 19:18:54 Andrius Ribas wrote:
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://svn.reviewboard.kde.org/r/6206/
>> -----------------------------------------------------------
>>
>> Review request for kde-windows.
>>
>>
>> Summary
>> -------
>>
>> Correct first item of KUrlNavigator to show the drive letters, instead of
>> "Custom Path" or "/" (the latter with "show full path" enabled).
>>
>>
>> Diffs
>> -----
>>
>>   trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1209174
>>
>> Diff: http://svn.reviewboard.kde.org/r/6206/diff
>>
>>
>> Testing
>> -------
>>
>> Tested using msvc 2008 on a windows 7 machine.
>>
>>
>> Screenshots
>> -----------
>>
>> Url navigator appearance
>>   http://svn.reviewboard.kde.org/r/6206/s/588/
>>
>>
>> Thanks,
>>
>> Andrius
> 
> 
> 
> 
> 
> _______________________________________________
> Kde-windows mailing list
> Kde-windows at kde.org
> https://mail.kde.org/mailman/listinfo/kde-windows



More information about the Kde-windows mailing list