KDE/kdelibs/kfile

[David Faure]

On Monday 24 August 2009, Andreas Pakulat wrote:
> On 24.08.09 08:08:30, Christian Ehrlicher wrote:
> > -------- Original-Nachricht --------
> >
> > > Datum: Mon, 24 Aug 2009 05:32:09 +0000
> > > Von: Casper van Donderen
> > > An: kde-commits at kde.org
> > > Betreff: KDE/kdelibs/kfile
> > >
> > > SVN commit 1014877 by cvandonderen:
> > >
> > > Fix crash in Winodws where the kfilemodule was not found because it was
> > > called libkfilemodule.
> > >
> > >
> > >  M  +1 -1      CMakeLists.txt
> > >
> > >
> > > --- trunk/KDE/kdelibs/kfile/CMakeLists.txt #1014876:1014877
> > > @@ -73,6 +73,6 @@
> > >  set(kfilemodule_SRCS
> > >    kfilemodule.cpp
> > >  )
> > > -kde4_add_plugin(kfilemodule WITH_PREFIX ${kfilemodule_SRCS})
> > > +kde4_add_plugin(kfilemodule ${kfilemodule_SRCS})
> > >  target_link_libraries(kfilemodule ${KDE4_KFILE_LIBS})
> > >  install(TARGETS kfilemodule DESTINATION ${PLUGIN_INSTALL_DIR})
> >
> > Do you know that WITH_PREFIX wasn't added because someone needed it?
>
> A quick svn blame indicates that this is how dfaure initially created it
> back in 2007. IIRC at that point there was no warning yet about plugins
> using lib-prefix, so I doubt there is any reason for the WITH_PREFIX.

I agree.

-- 
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).