[patch] Link Okteta for Windows (kdeutils/okteta/)

Friedrich W. H. Kossebau kossebau at kde.org
Fri May 16 11:38:35 CEST 2008


Am Freitag, 16. Mai 2008, um 01:29 Uhr, schrieb Patrick Spendrin:
> Friedrich W. H. Kossebau schrieb:
> > You may want to use the complete instructions for the parameterized
> > constructors, not just "{}". And the trailing ";" should go away.
> > Please also add a comment that this is a workaround for gcc 3 on windows,
> > so I know when to clean it up again. :)
>
> ok, fixed, so you can commit in the end.

Could also have been catched by you, if you ran the tests. What is your excuse 
you didn't? :) 

> > Other than that for the moved ctors/dtors in ksection.h please go ahead
> > if this helps with mingw.
>
> no the rest is ok, but the ctor/dtor thing would make it rather
> impossible to build.

Rather meant "Other than that, ...".
Or "Please commit yourself after you fixed the things I mentioned".
Your work, your commit. :)

Friedrich


More information about the Kde-windows mailing list