[patch] Link Okteta for Windows (kdeutils/okteta/)

[Friedrich W. H. Kossebau]

Hi Patrick,

Am Donnerstag, 15. Mai 2008, um 17:34 Uhr, schrieb Patrick Spendrin:
> Christian Ehrlicher schrieb:
> > Patrick Spendrin schrieb:
> >> Ok additionally to the rest, I experienced an internal compiler error
> >> on mingw. I spoke with the windows gcc maintainer Aaron LaFramboise
> >> and he said that the error is fixed in more recent gcc versions
> >> (upcoming 4.2/4.3 versions) and that it would be hard to fix gcc 3 on
> >> our own.
> >> Thus I removed the inline'd ctors/dtors and fixed the one linker error.
> >>
> >> As I don't want to interfere with somebody else, please say whether I
> >> can commit.
> >
> > Did you try moving them into the class definition?
>
> Seems to work, changed patch attached.


--- 8< ---
+    KSection( int startIndex, int endIndex ) {};
+    KSection( const KSection &other ) {};
+    KSection() {};
+    ~KSection() {};
--- 8< ---
You may want to use the complete instructions for the parameterized 
constructors, not just "{}". And the trailing ";" should go away.
Please also add a comment that this is a workaround for gcc 3 on windows, so I 
know when to clean it up again. :)

--- 8< ---
--- gui/test/CMakeLists.txt     (revision 807835)
+++ gui/test/CMakeLists.txt     (working copy)
@@ -38,7 +38,7 @@
 
 kde4_add_unit_test(coordrangetest TESTNAME libokteta-gui-coordrangetest  
${coordrangetest_SRCS})
 
-target_link_libraries(coordrangetest  ${KDE4_KDECORE_LIBS} 
${QT_QTTEST_LIBRARY})
+target_link_libraries(coordrangetest  ${KDE4_KDECORE_LIBS} 
${QT_QTTEST_LIBRARY} oktetacore )
--- 8< ---
Why is this needed? 

Other than that for the moved ctors/dtors in ksection.h please go ahead if 
this helps with mingw.

Cheers
Friedrich