[patch] KUniqueApplication: dbus service cleanup for Windows

Jarosław Staniek js at iidea.pl
Thu Mar 13 15:19:24 CET 2008


David Jarvie said the following, On 2008-03-13 14:59:
> On Thu, March 13, 2008 12:49 pm, Jarosław Staniek wrote:
>> For review.
>> As discussed before in the thread [1], there are problems
>> with running KUniqueApplications on Windows because previous dbus service
>> has
>> not been unregistered, resulting in "KUniqueApplication: Can't setup D-Bus
>> service. Probably already running." and forced app quit.
> 
> I'm not in a position to comment on your approach, but to avoid the code
> looking at first sight like '==' has accidentally been written as '=', it
> would read better as:
> 
> +  if (QDBusConnection::sessionBus().isConnected()
> +    && (dbusService = QDBusConnection::sessionBus().interface()) != 0)
> 

the ( ) are used to express that '=' is not a mistake... just like in many 
places around, including tryToInitDBusConnection()

-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice (http://www.kexi.pl/en, http://www.koffice.org/kexi)
  KDE Libraries for MS Windows (http://windows.kde.org)



More information about the Kde-windows mailing list