Some bugfixing!

[Christian Ehrlicher]

Michael Seydl schrieb:
> Christian Ehrlicher wrote:
>> Michael Seydl schrieb:
>>> Hi!
>>>
>>> Tried to build kdesupport from the scratch and encountered some 
>>> problems. I already prepared a patch against the latest trunk to fix 
>>> the building issues. Mostly fixes on the CMakeFiles.
>>>
>>> I'm working with CMake 2.6-patch2 from the kde-installer.
>>>
>>> Now everything works fine form me.
>>>
>>> Hope that helps.
>>>
>> Index: kdewin32/CMakeLists.txt
>> ===================================================================
>> --- kdewin32/CMakeLists.txt    (revision 895040)
>> +++ kdewin32/CMakeLists.txt    (working copy)
>> @@ -50,7 +50,7 @@
>>      add_subdirectory(tests)
>>  endif(BUILD_TESTS)
>>
>> -configure_file(${CMAKE_SOURCE_DIR}/include/winposix_export.h.cmake 
>> ${CMAKE_BINARY_DIR}/include/winposix_export.h)
>> +configure_file(${CMAKE_SOURCE_DIR}/kdewin32/include/winposix_export.h.cmake 
>> ${CMAKE_BINARY_DIR}/include/winposix_export.h)
>>
>>  # find the headers
>>  file(GLOB _source_headers  include/*.h)
>>
>>
>> This will break kdewin32 build when building standalone (which is the 
>> normal way).
>>
>>
>> Christian
> Thx for the hint! I'll remove that from the patch. And how about the 
> rest? Anything useful for you guys?
> 
I already commited some changes which should solve your problems with 
kdewin32.
the decibel patches look fine (although decibel isn't used on windows 
afaik) and should be send to the decibel maintainer if you won't check 
them in by your own.
And phonon's maintainer is mkretz - he can say more. Especially the 
comment for the cmake subdir looks strange.


Christian