Fix for (general, optimize, debug) link issue (was Re: kdelibs compile error)

Ralf Habacker ralf.habacker at freenet.de
Fri Aug 8 13:37:11 CEST 2008


Bill Hoffman schrieb:
> Brad King has committed a fix for this in CVS CMake:
> (If you could give it a try, I will merge it into the 2.6 branch for 
> 2.6.2.)
This does not help with the related issue. After a few more digging I 
recognized that the following method

cmComputeLinkDepends::AddLinkEntries(int depender_index,
                                     std::vector<std::string> const& libs)
{

is called with a libs parameter containing optimized and debug terms - 
the general terms are already been stripped anywhere before.

I guess that this method should sort out the libraries not intended for 
the given buildtype or this must be happen somewhere else - I haven't 
found out yet.
Ralf

>
>
> Update of /cvsroot/CMake/CMake/Source
> In directory public:/mounts/ram/cvs-serv12085/Source
>
> Modified Files:
>     cmTargetLinkLibrariesCommand.cxx
>     cmTargetLinkLibrariesCommand.h
> Log Message:
> ENH: Tolerate repeated link library types
>
> The "debug", "optimized", and "general" link library type specifier
> arguments to the target_link_library commands are sometimes repeated in
> user code due to variable expansion and other complications.  Instead of
> silently accepting the duplicates and trying to link to a bogus library
> like "optimized.lib", warn and ignore the earlier specifiers.
>
>
> Index: cmTargetLinkLibrariesCommand.h
> ===================================================================
> RCS file: /cvsroot/CMake/CMake/Source/cmTargetLinkLibrariesCommand.h,v
> retrieving revision 1.15
> retrieving revision 1.16
> RCS file: /cvsroot/CMake/CMake/Source/cmTargetLinkLibrariesCommand.cxx,v
> retrieving revision 1.25
> retrieving revision 1.26
>
>
> Thanks
>
> -Bill



More information about the Kde-windows mailing list