[Fwd: Re: *_EXPORT not needed for static members]

[Jarosław Staniek]

-------- Original Message --------
Subject: Re: *_EXPORT not needed for static members
Date: Wed, 20 Jun 2007 18:28:00 +0000
From: Jos van den Oever <jos at vandenoever.info>
To: Jaros³aw Staniek <js at iidea.pl>

On 6/20/2007, "Jaros³aw Staniek" <js at iidea.pl> wrote:

>Hello,
>See the attached patch, fixing compialtion for msvc.net (2003).
>*_EXPORT is not needed for static members since class is exported itself.
>
>As the static members are public, to increase cross-dll safety (simply, their
>behaviour is not well defined across runtimes), wouldn't it be nice to add
>static functions instead of variables? Similar to KGlobal::locale().
>

Thank for the patch and the suggestion. I applied and committed the
patch. With regards to using functions: nice idea, there would be some
copying overhead, but not too much. However, these strings are used by
_all_ analyzers and so the impact of changing the code would be large.
Also, the strings are not useful in static functions at all, so it
should be no problem, since they'll be only called when the program is
underway.

For FileInputStream, I moved the static to be private.

Cheers,
Jos


-- 
regards / pozdrawiam, Jaroslaw Staniek
  Sponsored by OpenOffice Polska (http://www.openoffice.com.pl/en) to work on
  Kexi & KOffice: http://www.kexi.pl/en, http://www.koffice.org
  KDE3 & KDE4 Libraries for MS Windows: http://kdelibs.com, http://www.kde.org