kdevelop configure problem

[Andreas Pakulat]

On 08.07.07 21:50:15, Ralf Habacker wrote:
> Andreas Pakulat schrieb:
> >On 08.07.07 20:51:13, Ralf Habacker wrote:
> >>===================================================================
> >>--- CMakeLists.txt	(revision 685357)
> >>+++ CMakeLists.txt	(working copy)
> >>@@ -2,8 +2,8 @@
> >>  set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/modules)
> >> +find_package(KDE4 REQUIRED)
> >> find_package(ZLIB REQUIRED)
> >>-find_package(KDE4 REQUIRED)
> >>    
> >
> >I don't see how that would make a difference, except if kdelibs needs
> >zlib (which would indicate its broken because it doesn't require it).
> >  
> the kde4  package adds some required basis pathes on win32 located in the 
> KDEWIN and KDEWIN32 package.

You mean to find zlib or what? If its for finding zlib, then the
FindZLIB.cmake in CMake 2.4.6 is buggy and you should file a bugreport.

> Another way would be to use
> 
> find_package(KDEWIN REQUIRED)
> find_package(ZLIB REQUIRED)
> find_package(KDE4 REQUIRED)

How would that work in systems that don't have KDEWIN???

BTW: I'm not objecting the move of the find_package, I'd just like to
understand the reasons.

> And actually I don't think ZLIB is needed in kdevplatform, thats
> >probably cruft from the move from kdevelop.
> >  
> okay, then this is obsolate.

I'll check this right away and remove it if its not needed.

> Index: FindKDevPlatform.cmake
> ===================================================================
> --- FindKDevPlatform.cmake	(revision 685407)
> +++ FindKDevPlatform.cmake	(working copy)
> @@ -31,7 +31,7 @@
>  
>  if(WIN32)
>      file(TO_CMAKE_PATH "$ENV{PROGRAMFILES}" _progFiles)
> -    set(_KDEVPLATFORM_INCLUDE_DIR ${KDE4_INCLUDE_DIR} ${_progFiles}/kdevplatform/include/kdevplatform)
> +    set(_KDEVPLATFORM_INCLUDE_DIR ${KDE4_INCLUDE_DIR} ${_progFiles}/kdevplatform/include)
>      set(_KDEVPLATFORM_LIB_DIR ${KDE4_LIB_DIR} ${_progFiles}/kdevplatform/lib)
>  endif(WIN32)

Uhm, right. Sorry I didn't test the last changes on win32. Please commit
this one.

Andreas

-- 
Caution: Keep out of reach of children.