win32 KUriFilterData problem with ERROR define

[Andreas Pakulat]

On 29.08.07 15:01:42, Saro Engels wrote:
> Ralf Habacker schrieb:
> > Hi,
> > 
> > in kio's KUriFilterData class 
> > (http://lxr.kde.org/source/KDE/kdelibs/kio/kio/kurifilter.h#098)
> > 
> > there are the following enums defined
> > 
> > m UriTypes { NET_PROTOCOL=0, LOCAL_FILE, LOCAL_DIR, EXECUTABLE, HELP, 
> > SHELL, BLOCKED, ERROR, UNKNOWN };
> > 
> > Because they are all uppercase at least the ERROR value collidates with 
> > a win 32 preprozessor macro definition.
> > 
> > I recognized this when compiling kdebase with msvc
> Same applies to mingw build:
> http://pskd.dyndns.org:8080/mingw-kdebase-log/build.log
> I remember building kdebase building on monday, so was this problem 
> introduced since then? They might not have got to far with it.

Well, maybe it was introduced in kdebase lately, but the class in kio
has these enums since quite some time.

Andreas (mentally kicking the people that write enum values in all
uppercase)

-- 
You are fairminded, just and loving.