kdesupport/kdewin32

[Paulo Jorge Guedes]

> -----Original Message-----
> From: Dirk Mueller [mailto:mueller at kde.org]
> Sent: quinta-feira, 29 de Junho de 2006 21:21
> To: kde-commits at kde.org
> Cc: KDE on Windows; Paulo Jorge Guedes
> Subject: Re: kdesupport/kdewin32
> 
> On Thursday, 29. June 2006 20:53, Paulo Jorge Guedes wrote:
> 
> > MinGw's dirent struct doesn't have d_type.
> > Should we replace it with our version like with msvc?
> 
> Well, alternatively I'd wrap this in a configure check. Previously I
> thought
> that only win32 is affected by the issue, but it seems it doesn't
build on
> OSX either (even though the man pages I found on developer.apple.com
> claims
> that OSX supports this field).

You already sent this mail :)

Like you said the better would be to define a macro in some
config*.cmake file and ifdef it.
I don't know the code but it's a fact that there is duplicated code (see
kded/vfolder_menu.cpp:951 and kdecore/kstandarddirs.cpp:475) which seems
to fit better wrapped in a function.

Paulo