D27181: Rename dialog displays also source file information

Méven Car noreply at phabricator.kde.org
Tue May 5 07:03:59 BST 2020


meven added a comment.


  In D27181#663426 <https://phabricator.kde.org/D27181#663426>, @papoteur wrote:
  
  > Should be OK now.
  
  
  You missed a couple of small things.
  
  Marking comments treated as "DONE" can be quite handy, to find the ones left quicker.

INLINE COMMENTS

> rthomsen wrote in singlefileplugin.cpp:123-124
> Please use `QFileInfo::birthTime()` and `QFileInfo::lastModified()`.

you missed here

> rthomsen wrote in libzipplugin.cpp:651
> Zip format doesn't store ctime, so guess it makes sense to pass mtime for both.

And here, but I guess, there is nothing to do.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D27181

To: papoteur, #ark, elvisangelaccio, rthomsen
Cc: rthomsen, meven, kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200505/de473192/attachment.html>


More information about the Kde-utils-devel mailing list