D26727: Fix font bug in ProgressBox

Nathaniel Graham noreply at phabricator.kde.org
Fri Jan 17 13:31:46 GMT 2020


ngraham added a comment.


  Please always add screenshots for patches that result in UI changes.

INLINE COMMENTS

> progressBox.cpp:33
>  #include <QFontDatabase>
> +#include <QGuiApplication>
> +#include <QPainter>

If indeed we no longer need to call `QGuiApplication::font()`, then we can get rid of this line too

> progressBox.cpp:34
> +#include <QGuiApplication>
> +#include <QPainter>
>  

Moving `#include <QPainter>` is unrelated

> progressBox.cpp:47
>  
> -    setFont(QFontDatabase::systemFont(QFontDatabase::FixedFont));
> +    setFont(QGuiApplication::font());
>      setSizePolicy(QSizePolicy::Minimum, QSizePolicy::Fixed);

Do we even need this at all anymore? Can we just remove it?

REPOSITORY
  R352 Filelight

REVISION DETAIL
  https://phabricator.kde.org/D26727

To: shubham, sandsmark, ngraham
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200117/607a4281/attachment.html>


More information about the Kde-utils-devel mailing list