D26357: Store entry icon in entry class

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Ark.
Herald added a subscriber: kde-utils-devel.
Herald added a project: Ark.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Building the icons datastructure is the most significant bottleneck when opening large archives. Knowing all the icons at loading time is unnecessary since most elements won't be visible anyway.
  This patch moves the icon storing into the Entry class where it is lazily determined the first time it is accessed. This improves the initial archive loading time significantly.

TEST PLAN
  It's hard to give exact numbers, but my main test archive (the Android NDK) went from ~3 seconds to load to "pretty much instant"

REPOSITORY
  R36 Ark

BRANCH
  megaopto

REVISION DETAIL
  https://phabricator.kde.org/D26357

AFFECTED FILES
  kerfuffle/archiveentry.cpp
  kerfuffle/archiveentry.h
  part/archivemodel.cpp
  part/archivemodel.h
  part/overwritedialog.cpp
  part/overwritedialog.h
  part/part.cpp

To: nicolasfella, #ark
Cc: kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200102/cb25a908/attachment-0001.html>