D25565: Optimize ArchiveModel::cleanFileName

Nicolas Fella noreply at phabricator.kde.org
Thu Jan 2 00:15:53 GMT 2020


nicolasfella added a comment.


  I tested it by opening a rather large zip (the Android NDK).
  
  The culprit seems to be the unneeded re-creation of the QRegularExpression object in the loop. Since we don't change it we can share it between the function calls which simplifies the patch and keeps the exact original behavior.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D25565

To: nicolasfella, #ark
Cc: elvisangelaccio, kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200102/72f151da/attachment.html>


More information about the Kde-utils-devel mailing list