D27181: Rename dialog displays also source file information

[Méven Car]

meven added a comment.


  Nice first patch @papoteur , seems good to me.
  Great on you pushing through your patch to phabricator.
  
  Please fix the few formatting issues.
  Then we leave the final say to Ark maintainer @elvisangelaccio

INLINE COMMENTS

> queries.cpp:87
> +    m_data[QStringLiteral("filename")] = QDir::fromNativeSeparators(QFile::decodeName(archive_entry_pathname(entry)));
> +	m_entry = entry;
> +}

indentation seems wrong here.

> queries.cpp:95
>      QApplication::setOverrideCursor(QCursor(Qt::ArrowCursor));
> +    QPointer<KIO::RenameDialog> dialog ;
>  

A space too much

> queries.h:72
>  
> -    QueryData m_data;
> +    QueryData m_data; 
> +    struct archive_entry *m_entry;

Please remove this unneeded end space

> queries.h:104
>      bool m_noRenameMode;
> -    bool m_multiMode;
> +    bool m_multiMode; 
> +    bool m_from_archive;

Same

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D27181

To: papoteur, #ark, elvisangelaccio
Cc: meven, kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200208/448b18cf/attachment.html>