D27181: Rename dialog displays also source file information
Papoteur Me
noreply at phabricator.kde.org
Wed Feb 5 22:01:50 GMT 2020
papoteur created this revision.
papoteur added a reviewer: Ark.
papoteur added a project: Ark.
Herald added a subscriber: kde-utils-devel.
papoteur requested review of this revision.
REVISION SUMMARY
This patch is for solving:
Bug 403146 - Extracting suggests replacement file with info of destination file
I have tested with ark 19.04.0. It allows to have size and date of the source file from the archive, not the destination information.
The modifications are :
- call overwriteQuery with the entry, not only the entry name.
- overloading the overwriteQuery to accept the entry.
- in case of call with query, call renameDialog with the name without formatting it with fromLocalFile, and adding date and size of the source, read from entry.
When QUrl is not a local file in renameDialog, displayed value are from the parameters passed with the call.
TEST PLAN
Create an archive.
Modify a file which copy is in the archive
Open it with ark, extract the archive at the same location. A dialog opens to replace the file. At left, the information (date, size) should be the information before modification, and at right, from the modified file.
Extract or not.
REPOSITORY
R36 Ark
REVISION DETAIL
https://phabricator.kde.org/D27181
AFFECTED FILES
kerfuffle/CMakeLists.txt
kerfuffle/queries.cpp
kerfuffle/queries.h
plugins/libarchive/libarchiveplugin.cpp
To: papoteur, #ark
Cc: kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200205/0a3f6827/attachment.html>
More information about the Kde-utils-devel
mailing list