D27181: Rename dialog displays also source file information

[Ragnar Thomsen]

rthomsen requested changes to this revision.
rthomsen added a comment.
This revision now requires changes to proceed.


  I think it makes sense to always require specifying ctime, mtime and size, so please add the three values as arguments to the constructor of `OverwriteQuery` so we can get rid of `setSourceData()` and `m_from_archive`.

INLINE COMMENTS

> queries.cpp:44
> +#include <QDateTime>
>  
>  namespace Kerfuffle

The data you set are not used when sourceUrl points to an existing local file (see link <https://api.kde.org/frameworks/kio/html/renamedialog_8cpp_source.html#l00217>).
So sourceUrl should be set to just the filename i.e.:
`QUrl sourceUrl = QUrl(m_data.value(QStringLiteral("filename")).toString());`

REVISION DETAIL
  https://phabricator.kde.org/D27181

To: papoteur, #ark, elvisangelaccio, rthomsen
Cc: rthomsen, meven, kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20200426/a1f3610c/attachment.html>