D24213: Add live conversions between numerical bases

[Rolf Eike Beer]

dakon requested changes to this revision.
dakon added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcalc.cpp:1882
> +	decDisplay->setText(decimal_str);
> +	binDisplay->setText(QString::number(decimal_str.toULongLong(), 2));
> +	octDisplay->setText(QString::number(decimal_str.toULongLong(), 8));

You convert the KNumber to a string in line 1879, and then convert it back to an uint64 here to be able to convert it back to a string. This does not make any sense. Put it in an quint64 and use that in all following steps.

REVISION DETAIL
  https://phabricator.kde.org/D24213

To: umanovskis, #vdg, cfeck, dakon
Cc: dakon, kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20191007/96d5379c/attachment.html>