D24213: Add live conversions between numerical bases

[Rolf Eike Beer]

dakon added inline comments.

INLINE COMMENTS

> kcalc.cpp:103
>  
> +        base_conversion_labels_ = { binDisplay, hexDisplay, decDisplay, octDisplay };
> +

Looks like you did tab indentation here, but everything else is using spaces. Could also be a problem with the web view, please double check.

> kcalc.cpp:1879
> +void KCalculator::slotBaseModeAmountChanged(KNumber number) {
> +	QString decimal_str = QStringLiteral("%1").arg(number.toUint64(), 0, 10);
> +

Looking again on this, can't you simply use QString::number() here?

REVISION DETAIL
  https://phabricator.kde.org/D24213

To: umanovskis, #vdg, cfeck, dakon
Cc: dakon, kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20191007/a525e865/attachment.html>