D25377: Don't covert icons to pixmaps multiple times

Nicolas Fella noreply at phabricator.kde.org
Mon Nov 18 19:36:08 GMT 2019


nicolasfella created this revision.
nicolasfella added a reviewer: Ark.
Herald added a subscriber: kde-utils-devel.
Herald added a project: Ark.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We don't need to convert the icon which is loaded by name to a pixmap here. The conversion happens later in the DecorationRole data() call.

TEST PLAN
  Open archive. Icons in the file list appear and are properly sized.
  Trigger overwrite dialog. Icons appear and are properly sized.
  
  Verified performance improvement with hotspot

REPOSITORY
  R36 Ark

BRANCH
  conv

REVISION DETAIL
  https://phabricator.kde.org/D25377

AFFECTED FILES
  part/archivemodel.cpp

To: nicolasfella, #ark
Cc: kde-utils-devel, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20191118/78a0dd66/attachment.html>


More information about the Kde-utils-devel mailing list