D24911: Check zstd and lzma are really available

[Elvis Angelaccio]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> pluginmanager.cpp:181
>  
> +    QByteArray libArchiveDependencies;
> +    bool dependenciesFetched = false;

Nitpick: it's called libarchive, not libArchive ;)

> pluginmanager.cpp:285
>  
> -bool PluginManager::libarchiveHasLzo()
> -{
> +QByteArray PluginManager::libarchiveDependencies() {
>      // Step 1: look for the libarchive plugin, which is built against libarchive.

Nitpick: opening brace goes to next line

> pluginmanager.h:141
> +    /**
> +     * @return Thes dependencies of libarchive
> +     */

Type: "The"

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D24911

To: meven, elvisangelaccio, rthomsen
Cc: kde-utils-devel, #ark, fbampaloukas, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20191109/1ed42a94/attachment.html>