D19953: Fix progress info for CreateJob

[Ragnar Thomsen]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen added a project: Ark.
Herald added subscribers: Ark, kde-utils-devel.
rthomsen requested review of this revision.

REVISION SUMMARY
  Progress info is currently broken when creating archives using `CreateJob`. This happens for example when the user creates an archive through the `KFileItemAction` in Dolphin.
  
  See bug 382599 <https://bugs.kde.org/show_bug.cgi?id=382599>.
  
  This happens because `CreateJob` uses a nested `AddJob` and the `percent` signal of the `AddJob` is not forwarded to `CreateJob`. It was necessary to create a new signal `PercentFromNestedJob` in the `Job` class because connecting to `KJob::percent` did not work. I suspect this is caused by `KJob` also having a public member function `percent` and Qt confusing the signal and the member function. If it is possible to somehow force Qt to connect to the signal, then the `PercentFromNestedJob` is not necessary.

TEST PLAN
  Create a sufficiently large archive (e.g. rar archive) from Dolphin using the right-click menu. Observe that progress is correctly shown in system tray.
  
  Alternatively use: `ark --add-to <archive name> <files to add>`

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D19953

AFFECTED FILES
  kerfuffle/jobs.cpp
  kerfuffle/jobs.h

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190321/13f0d546/attachment.html>