D21781: Fix for Tree

[Harald Sitter]

sitter added a comment.


  Can you please explain what bug you intend to fix here and how to test it?
  
  I am not sure I understand what you are fixing in the append....
  The way listing works is that we open a dir, iterate its entries, for each file entry we append a File* for each directory we recurse and then append the returned Folder* making the current Folder the parent and the returned Folder the child. That is to say: once a child gets a parent the child is complete, there are no more appends happening to that child.
  
  You could add a `Q_ASSERT(!parent());` to the top of the append and it should never crash there.
  
  The remove change looks good though.

REPOSITORY
  R352 Filelight

REVISION DETAIL
  https://phabricator.kde.org/D21781

To: bruleherman, aacid, sitter
Cc: ngraham, kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20190617/8f7f3454/attachment.html>